SourceLevel · hexpm/hexpm · #1376

Looks like something went wrong while reviewing your code

The Credo engine failed with:

engine credo:stable failed with status 1 and stderr 
** (ArgumentError) argument error
    :erlang.binary_to_existing_atom("Elixir.Credo.Check.Warning.NameRedeclarationByAssignment", :utf8)
    (elixir 1.11.3) src/elixir_aliases.erl:109: :elixir_aliases.safe_concat/1
    (credo 1.4.1) lib/credo/exs_loader.ex:79: Credo.ExsLoader.process_exs/1
    (elixir 1.11.3) lib/enum.ex:1411: Enum."-map/2-lists^map/1-0-"/2
    (elixir 1.11.3) lib/enum.ex:1411: Enum."-map/2-lists^map/1-0-"/2
    (credo 1.4.1) lib/credo/exs_loader.ex:106: Credo.ExsLoader.process_map_item/2
    (credo 1.4.1) lib/credo/exs_loader.ex:100: Credo.ExsLoader.process_map/2
    (elixir 1.11.3) lib/enum.ex:1411: Enum."-map/2-lists^map/1-0-"/2

17 Clarity issues found
(Out of 63 issues found)

Identifier 'hexpm_billing_checkout' is not in camel case.

Reported by ESLint

Enforce the usage of camel case to have a consistent codebase.
assets/js/app.js
window.app = new App()
window.hexpm_billing_checkout = app.billing_checkout
window.$ = $
window.liveSocket = liveSocket
Read more about it here
Clarity ESLint JavaScript Quick fix
Strings must use doublequote.

Reported by ESLint
assets/js/app.js
response.errors +
'</div>'
)
})
Read more about it here
Clarity ESLint JavaScript Quick fix

Strings must use doublequote.

Reported by ESLint

                '<div class="alert alert-danger" role="alert">' +
    
                '<strong>Failed to update payment method</strong><br>' +
    
                response.errors +
    
                '</div>'

Strings must use doublequote.

Reported by ESLint

              $('div.flash').html(
    
                '<div class="alert alert-danger" role="alert">' +
    
                '<strong>Failed to update payment method</strong><br>' +
    
                response.errors +

Strings must use doublequote.

Reported by ESLint

              var response = JSON.parse(data.responseText);
    
              $('div.flash').html(
    
                '<div class="alert alert-danger" role="alert">' +
    
                '<strong>Failed to update payment method</strong><br>' +

Extra semicolon.

Reported by ESLint

            .fail(function (data) {
    
              var response = JSON.parse(data.responseText);
    
              $('div.flash').html(
    
                '<div class="alert alert-danger" role="alert">' +

Identifier '_csrf_token' is not in camel case.

Reported by ESLint

Enforce the usage of camel case to have a consistent codebase.

        billing_checkout(token) {
    
          $.post(window.hexpm_billing_post_action, { token: token, _csrf_token: window.hexpm_billing_csrf_token })
    
            .done(function (data) {
    
              window.location.reload()

Identifier 'billing_checkout' is not in camel case.

Reported by ESLint

Enforce the usage of camel case to have a consistent codebase.
assets/js/app.js
billing_checkout(token) {
$.post(window.hexpm_billing_post_action, { token: token, _csrf_token: window.hexpm_billing_csrf_token })
.done(function (data) {
Read more about it here
Clarity ESLint JavaScript Quick fix

Extra semicolon.

Reported by ESLint

          // Highlight syntax
    
          hljs.registerLanguage('elixir', elixir);
    
          hljs.initHighlightingOnLoad()

Strings must use doublequote.

Reported by ESLint
assets/js/app.js
// Highlight syntax
hljs.registerLanguage('elixir', elixir);
hljs.initHighlightingOnLoad()
Read more about it here
Clarity ESLint JavaScript Quick fix

Meet SourceLevel, an All-in-one Data & Analytics for Engineering Teams

#1376 - Daily Review
Reviewed in less than a minute, Wed, 20 Oct 2021 12:00:34 -0300

Looks like something went wrong while reviewing your code

17 Clarity issues found
(Out of 63 issues found)

Identifier 'hexpm_billing_checkout' is not in camel case.

Strings must use doublequote.

Strings must use doublequote.

Strings must use doublequote.

Strings must use doublequote.

Extra semicolon.

Identifier '_csrf_token' is not in camel case.

Identifier 'billing_checkout' is not in camel case.

Extra semicolon.

Strings must use doublequote.

Meet SourceLevel, an All-in-one Data & Analytics for Engineering Teams

#1376 - Daily Review Reviewed in less than a minute, Wed, 20 Oct 2021 12:00:34 -0300

Identifier 'hexpm_billing_checkout' is not in camel case.

Strings must use doublequote.

Strings must use doublequote.

Strings must use doublequote.

Strings must use doublequote.

Extra semicolon.

Identifier '_csrf_token' is not in camel case.

Identifier 'billing_checkout' is not in camel case.

Extra semicolon.

Strings must use doublequote.

#1376 - Daily Review
Reviewed in less than a minute, Wed, 20 Oct 2021 12:00:34 -0300